openssl: Add error checks for CMS_get1_certs() and CMS_get1_crls()#21957
Open
ndossche wants to merge 1 commit intophp:masterfrom
Open
openssl: Add error checks for CMS_get1_certs() and CMS_get1_crls()#21957ndossche wants to merge 1 commit intophp:masterfrom
ndossche wants to merge 1 commit intophp:masterfrom
Conversation
These allocate new stacks and add the certificates to those as clones. So these aren't trivial refcount increases and might fail. Unfortunately, an empty stack also results in a NULL return, so to distinguish an empty stack from a failure we check the error stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These allocate new stacks and add the certificates to those as clones. So these aren't trivial refcount increases and might fail. Unfortunately, an empty stack also results in a NULL return, so to distinguish an empty stack from a failure we check the error stack.
Note: this was found by an experimental static-dynamic hybrid analyser I'm developing.